Move Report Chart Generation to a Separate Script #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencerfinnell Thanks for taking the lead on this. The JavaScript improvements are amazing and frankly above my head! So I appreciate you diving in. |
|
@spencerfinnell still working on this or ready for testing? |
|
Good to test! The compiled JS is included in the branch so you shouldn't need to run anything. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly enqueuing ChartJS means the position it is loaded cannot be guaranteed. If it is used by another script that outputs in the footer it will be moved to the footer as well. This means the inline Javascript printed in the page to render charts will be run immediately and without the proper dependency (charts are broken in
release/3.0currently).This PR fixes that by building charts in a JS file that is dependent on the main reporting javascript, which can be properly enqueued.
I need a bit of input on some potential abstraction that could be done to facilitate the extra data that was added to the
build_config()method in the chart manifest class. @DrewAPicture I think that's you?To test:
npm run dev(I can commit the built scripts if needed)To do: